fix: Add Javadoc for rest transport server-side components#678
Merged
ehsavoie merged 3 commits intoa2aproject:mainfrom Mar 9, 2026
Merged
fix: Add Javadoc for rest transport server-side components#678ehsavoie merged 3 commits intoa2aproject:mainfrom
ehsavoie merged 3 commits intoa2aproject:mainfrom
Conversation
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces comprehensive Javadoc documentation for the REST transport server-side components. This significantly improves the clarity and maintainability of the codebase by explaining the purpose, functionality, and usage of various classes and methods. The Javadoc covers A2AServerRoutes, CallContextFactory, QuarkusRestTransportMetadata, RestContextKeys, RestHandler, and MultiSseSupport, detailing their roles, API patterns, authentication, streaming support, error handling, and context creation. This is a valuable addition that will aid future development and onboarding.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Collaborator
|
Thanks @kabir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #480